Skip to content

Revert "Support Fields API in conditional ingest processors" #131452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

Revert "Support Fields API in conditional ingest processors" #131452

merged 1 commit into from
Jul 17, 2025

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jul 17, 2025

Reverts #121914 as this causes benchmark failures

@eyalkoren eyalkoren requested a review from gbanasiak July 17, 2025 14:25
@eyalkoren eyalkoren self-assigned this Jul 17, 2025
@eyalkoren eyalkoren requested a review from a team as a code owner July 17, 2025 14:25
@eyalkoren eyalkoren added >test-failure Triaged test failures from CI :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Jul 17, 2025
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v9.2.0 needs:risk Requires assignment of a risk label (low, medium, blocker) labels Jul 17, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 17, 2025

Pinging @elastic/es-data-management (Team:Data Management)

@gbanasiak gbanasiak requested a review from jdconrad July 17, 2025 14:36
gbanasiak
gbanasiak approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wouldn't hurt if @elastic/es-core-infra takes a look too.

@eyalkoren eyalkoren removed the :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP label Jul 17, 2025
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Data Management Meta label for data/management team labels Jul 17, 2025
@gbanasiak gbanasiak added the :Core/Infra/Core Core issues without another label label Jul 17, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label labels Jul 17, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 17, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

@jdconrad jdconrad merged commit 221998d into main Jul 17, 2025
34 checks passed
@jdconrad jdconrad deleted the revert-121914-support-dotted-fields-in-ingest-processors branch July 17, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdconrad jdconrad jdconrad approved these changes

@gbanasiak gbanasiak gbanasiak approved these changes

Assignees

@eyalkoren eyalkoren

Labels

:Core/Infra/Core Core issues without another label needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eyalkoren @elasticsearchmachine @jdconrad @gbanasiak